You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "geruh (via GitHub)" <gi...@apache.org> on 2025/09/19 00:15:30 UTC
[PR] Remove user flag from poetry installation [iceberg-python]
geruh opened a new pull request, #2486:
URL: https://github.com/apache/iceberg-python/pull/2486
related to #2425
# Rationale for this change
Removing the user flag from the poetry installation to allow users who want to install poetry into a separate dedicated virtual environment.
This virtual environment must be separate from the environment in which we install the iceberg-python repo.
## Are these changes tested?
Yes manual testing
```
> python3 -m venv ~/.venvs/poetry
> source ~/.venvs/poetry/bin/activate
> echo $VIRTUAL_ENV
/Users/geru/.venvs/poetry
> python -m pip install -U pip setuptools wheel
> poetry --version
Poetry (version 2.1.4)
> poetry show -v
Using virtualenv: /Users/geru/workspace/iceberg-python/.venv
> poetry install
SUCCESS
```
## Are there any user-facing changes?
no
cc: @kevinjqliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove user flag from poetry installation [iceberg-python]
Posted by "jayceslesar (via GitHub)" <gi...@apache.org>.
jayceslesar commented on PR #2486:
URL: https://github.com/apache/iceberg-python/pull/2486#issuecomment-3312931716
> thats a good case to check. @jayceslesar can you double check if this resolved your issue?
That worked!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove user flag from poetry installation [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #2486:
URL: https://github.com/apache/iceberg-python/pull/2486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove user flag from poetry installation [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2486:
URL: https://github.com/apache/iceberg-python/pull/2486#issuecomment-3312920583
thats a good case to check. @jayceslesar can you double check if this resolved your issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove user flag from poetry installation [iceberg-python]
Posted by "jayceslesar (via GitHub)" <gi...@apache.org>.
jayceslesar commented on PR #2486:
URL: https://github.com/apache/iceberg-python/pull/2486#issuecomment-3312884835
ah I wonder if this has been the source of my issues, I was just manually created a venv with uv, installing poetry and then running `make install-dependencies` but I imagine this might fix? It also might mess with CI but I suppose we will find out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove user flag from poetry installation [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #2486:
URL: https://github.com/apache/iceberg-python/pull/2486#issuecomment-3313156833
Thanks @geruh and @jayceslesar for verifying :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org