You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/22 23:39:47 UTC
[GitHub] [geode] rhoughton-pivot opened a new pull request #5283: GEODE-8289: Add gradle task chaining for geode-old-versions:clean
rhoughton-pivot opened a new pull request #5283:
URL: https://github.com/apache/geode/pull/5283
Authored-by: Robert Houghton <rh...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [n/a] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill edited a comment on pull request #5283: GEODE-8289: Add gradle task chaining for geode-old-versions:clean
Posted by GitBox <gi...@apache.org>.
Bill edited a comment on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648402388
I tried this and it appears to clean up the `geode-old-versions/build` dir but not the dirs for the "synthesized" subprojects:
<img width="876" alt="image" src="https://user-images.githubusercontent.com/4002/85458568-1dccd700-b556-11ea-87e4-9c70b4e3cde1.png">
On the plus side, the subproject directories _are_ empty now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot edited a comment on pull request #5283: GEODE-8289: Add gradle task chaining for geode-old-versions:clean
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot edited a comment on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648404584
> I tried this and it appears to clean up the `geode-old-versions/build` dir but not the dirs for the "synthesized" subprojects:
>
> <img alt="image" width="876" src="https://user-images.githubusercontent.com/4002/85458568-1dccd700-b556-11ea-87e4-9c70b4e3cde1.png">
>
> On the plus side, the subproject directories _are_ empty now.
The subprojects will exist for sure. I think those exist just by having intellij parse your Gradle build, without even building anything. The *build* (artifact) directory is gone, but the project directory itself remains. Also, if you run `./gradlew tasks` from a clean checkout, the project directories themselves are created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot merged pull request #5283: GEODE-8289: Add gradle task chaining for geode-old-versions:clean
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot merged pull request #5283:
URL: https://github.com/apache/geode/pull/5283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill edited a comment on pull request #5283: GEODE-8289: Add gradle task chaining for geode-old-versions:clean
Posted by GitBox <gi...@apache.org>.
Bill edited a comment on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648402388
I tried this and it appears to clean up the `geode-old-versions/build` dir but not the dirs for the "synthesized" subprojects:
<img width="876" alt="image" src="https://user-images.githubusercontent.com/4002/85458568-1dccd700-b556-11ea-87e4-9c70b4e3cde1.png">
On the plus side, the subproject directories _are_ empty now.
The problem I foresee with leaving the suproject directories in place is that if/when the list of subprojects set up in `settings.gradle` changes, it will become out-of-sync w/ the subproject directories in this module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #5283: GEODE-8289: Add gradle task chaining for geode-old-versions:clean
Posted by GitBox <gi...@apache.org>.
rhoughton-pivot commented on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648404584
> I tried this and it appears to clean up the `geode-old-versions/build` dir but not the dirs for the "synthesized" subprojects:
>
> <img alt="image" width="876" src="https://user-images.githubusercontent.com/4002/85458568-1dccd700-b556-11ea-87e4-9c70b4e3cde1.png">
>
> On the plus side, the subproject directories _are_ empty now.
The subprojects will exist for sure. I think those exist just by having intellij parse your Gradle build, without even building anything. The *build* (artifact) directory is gone, but the project directory itself remains.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] Bill commented on pull request #5283: GEODE-8289: Add gradle task chaining for geode-old-versions:clean
Posted by GitBox <gi...@apache.org>.
Bill commented on pull request #5283:
URL: https://github.com/apache/geode/pull/5283#issuecomment-648402388
I tried this and it appears to clean up the `geode-old-versions/build` dir but not the dirs for the "synthesized" subprojects:
<img width="876" alt="image" src="https://user-images.githubusercontent.com/4002/85458568-1dccd700-b556-11ea-87e4-9c70b4e3cde1.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org