You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/06 16:35:41 UTC

[GitHub] [airflow] terekete commented on a change in pull request #13478: Google Dataflow Flex Operator to handle no Job Type

terekete commented on a change in pull request #13478:
URL: https://github.com/apache/airflow/pull/13478#discussion_r552784989



##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -377,29 +377,32 @@ def _check_dataflow_job_state(self, job) -> bool:
         :rtype: bool
         :raise: Exception
         """
-        if self._wait_until_finished is None:
-            wait_for_running = job['type'] == DataflowJobType.JOB_TYPE_STREAMING

Review comment:
       agree - this is a better way, have changed for review.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org