Re: [PR] Core: Fix caching table with metadata table names [iceberg]

["gaborkaszab (via GitHub)" <gi...@apache.org>]

gaborkaszab commented on code in PR #11123:
URL: https://github.com/apache/iceberg/pull/11123#discussion_r1877738556


##########
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##########
@@ -145,22 +146,26 @@ public Table loadTable(TableIdentifier ident) {
     }
 
     if (MetadataTableUtils.hasMetadataTableName(canonicalized)) {

Review Comment:
   Finally I had some time to take a deeper look on this. You are right, with my above proposal we won't run the specific code for metadata tables like caching the underlying table and sharing the table operations.
   
   I did find a way simpler version of this fix, however. I also wrote some tests in TestCachingCatalog. https://github.com/gaborkaszab/iceberg/commit/c1eca8b09e9bb8eb595fa5ce5e16e6f50636a783
   What do you think? Would you mind if I opened an alternative fix PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org