You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wankunde (via GitHub)" <gi...@apache.org> on 2023/03/01 03:21:50 UTC

[GitHub] [spark] wankunde commented on pull request #40157: [SPARK-42551][SQL] Support subexpression elimination in FilterExec

wankunde commented on PR #40157:
URL: https://github.com/apache/spark/pull/40157#issuecomment-1449275235

   Hi, @cloud-fan, unlike ProjectExec and HashAggregateExec, FilterExec should handle subexpression elimination in a special way. So if any of the filter expressions return false, we will be able to skip evaluating the remaining common expressions.
   
   Could we support CSE for the other operations in the following PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org