[GitHub] [accumulo] keith-turner commented on a change in pull request #1103: Create AbstractServer type for Accumulo servers

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #1103: Create AbstractServer type for Accumulo servers
URL: https://github.com/apache/accumulo/pull/1103#discussion_r276752961
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/Master.java
 ##########
 @@ -1277,14 +1280,23 @@ public void run() throws IOException, InterruptedException, KeeperException {
     } else {
       processor = new Processor<>(rpcProxy);
     }
-    ServerAddress sa = TServerUtils.startServer(context, hostname, Property.MASTER_CLIENTPORT,
-        processor, "Master", "Master Client Service Handler", null, Property.MASTER_MINTHREADS,
-        Property.MASTER_THREADCHECK, Property.GENERAL_MAX_MESSAGE_SIZE);
+    ServerAddress sa;
+    try {
+      sa = TServerUtils.startServer(context, getHostname(), Property.MASTER_CLIENTPORT, processor,
+          "Master", "Master Client Service Handler", null, Property.MASTER_MINTHREADS,
+          Property.MASTER_THREADCHECK, Property.GENERAL_MAX_MESSAGE_SIZE);
+    } catch (UnknownHostException e) {
+      throw new IllegalStateException("Unable to start server", e);
 
 Review comment:
   Could include the host+port in error message.  Sometimes this type of info is useful when on the receiving end.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services