You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/21 05:28:23 UTC
[GitHub] [commons-ognl] arturobernalg opened a new pull request #45: Redundant calls of java.lang.Class methods.
arturobernalg opened a new pull request #45:
URL: https://github.com/apache/commons-ognl/pull/45
Remove redundant calls of java.lang.Class methods. Replaced with object instanceof
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] lukaszlenart merged pull request #45: Redundant calls of java.lang.Class methods.
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #45:
URL: https://github.com/apache/commons-ognl/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] arturobernalg commented on pull request #45: Redundant calls of java.lang.Class methods.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #45:
URL: https://github.com/apache/commons-ognl/pull/45#issuecomment-865257835
HI @lukaszlenart
I think we don't need check dynamic if are assignment-compatible. IMO `isInstance` should be use when are using reflection. Off course this can be subjective :)
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] lukaszlenart commented on pull request #45: Redundant calls of java.lang.Class methods.
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #45:
URL: https://github.com/apache/commons-ognl/pull/45#issuecomment-866286656
> * I am repeating myself again, and again here: 25 files changed in one go? Are you kidding me?
I'm fine with having all the same changes as a one commit - in this case changes to all the files are related to the same thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] arturobernalg commented on pull request #45: Redundant calls of java.lang.Class methods.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #45:
URL: https://github.com/apache/commons-ognl/pull/45#issuecomment-866256991
Hi @jochenw
I don't think "instanceof" it's better. IMO they should use in different way. "Determines if the specified Object is assignment-compatible with the object represented by this Class. This method is the dynamic equivalent of the Java language instanceof operator. "
Regarding with the numbers of file, I´m trying to create small PR, but in sometimes its difficult split the PR and been coherent with the change
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] arturobernalg commented on pull request #45: Redundant calls of java.lang.Class methods.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #45:
URL: https://github.com/apache/commons-ognl/pull/45#issuecomment-865257835
HI @lukaszlenart
I think we don't need check dynamic if are assignment-compatible. IMO `isInstance` should be use when are using reflection. Off course this can be subjective :)
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-ognl] lukaszlenart merged pull request #45: Redundant calls of java.lang.Class methods.
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #45:
URL: https://github.com/apache/commons-ognl/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org