You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/08/01 02:16:37 UTC
[PR] [SPARK-58492] Support window functions with `Window`, `WindowSpec` and `Column.over` [spark-connect-swift]
dongjoon-hyun opened a new pull request, #465:
URL: https://github.com/apache/spark-connect-swift/pull/465
### What changes were proposed in this pull request?
This PR aims to support window functions in `SparkConnect` module.
- New `Window` and `WindowSpec` types with `partitionBy`, `orderBy`, `rowsBetween`, `rangeBetween`, and the `unboundedPreceding`/`unboundedFollowing`/`currentRow` constants.
- New `Column.over(_:)` and `Column.over()` building `Expression.Window`.
- New window functions in `WindowFunctions.swift`: `row_number`, `rank`, `dense_rank`, `percent_rank`, `ntile`, `cume_dist`, `lag`, `lead`, `nth_value`.
```swift
let window = Window.partitionBy("dept").orderBy(col("salary").desc())
df.withColumn("rank", rank().over(window))
```
### Why are the changes needed?
To provide window function support like the Scala/PySpark clients.
### Does this PR introduce _any_ user-facing change?
No. This is a new feature addition.
### How was this patch tested?
Pass the CIs with the newly added `WindowTests` test suite.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58492] Support window functions with `Window`, `WindowSpec` and `Column.over` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #465:
URL: https://github.com/apache/spark-connect-swift/pull/465#issuecomment-5149656172
Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58492] Support window functions with `Window`, `WindowSpec` and `Column.over` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #465: [SPARK-58492] Support window functions with `Window`, `WindowSpec` and `Column.over`
URL: https://github.com/apache/spark-connect-swift/pull/465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58492] Support window functions with `Window`, `WindowSpec` and `Column.over` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #465:
URL: https://github.com/apache/spark-connect-swift/pull/465#issuecomment-5149654942
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org