[GitHub] [iceberg] danielcweeks commented on pull request #5228: Build - Add Git Build Properties File via Plugin

[GitBox <gi...@apache.org>]

danielcweeks commented on PR #5228:
URL: https://github.com/apache/iceberg/pull/5228#issuecomment-1179432740

   @kbendick I'm not sure which path was settled on for the properties file.  I see both `/build/iceberg-build.properties` and `core/build/iceberg-build.properties` paths referenced.
   
   @rdblue I think you may have meant `core/build/iceberg-build.properties` which you referenced in the other PR, but that's not sufficient to get into a jar.
   
   We can either produce a top-level `iceberg-build.properties` and then later copy it into location for the jar to pick it up or we can set the location to `gitPropertiesResourceDir = file("${rootDir}/core/build/resources/main")`, which will put it in a place where it will be included.
   
   We could also update the Jar task to include the top-level file (assuming you can reference from the project root).
   
   Whether we want to do it in this PR or not, we should make sure that building the jar should generate the file so we don't require calling a specific task to get the build information included.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org