You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "chengxunhuang (via GitHub)" <gi...@apache.org> on 2024/11/12 08:05:01 UTC
[I] SQL parser support kingbase [shardingsphere]
chengxunhuang opened a new issue, #33628:
URL: https://github.com/apache/shardingsphere/issues/33628
## Feature Request
**For English only**, other languages will not be accepted.
Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will **close it**.
Please answer these questions before submitting your issue. Thanks!
### Describe the feature you would like.
I want to support Database kingbase！About half a month
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "wh-zxt-01 (via GitHub)" <gi...@apache.org>.
wh-zxt-01 commented on issue #33628:
URL: https://github.com/apache/shardingsphere/issues/33628#issuecomment-2469966127
> * 作为一名从未接触过 kingbase 的开发人员，我认为法律方面的讨论不应该在私人邮件中发生。我认为 kingbase 开发人员应该澄清是否存在没有法律问题的 docker 镜像，就像 IBM 员工在[SQL Server 容器改进中关于许可](https://github.com/testcontainers/testcontainers-java/issues/2496#issuecomment-610402944)[ testcontainers/testcontainers-java#2496 (评论)](https://github.com/testcontainers/testcontainers-java/issues/2496#issuecomment-610402944)一样。[](https://github.com/testcontainers/testcontainers-java/issues/2496#issuecomment-610402944)
> * 否则，当前的问题似乎毫无意义。
> * 创建 sql 解析模块确实没有合法性问题，问题是其他 shardingsphere 开发人员如何合法地测试这些模块。如果其他开发人员不能合法地编写集成测试，那么将来肯定会造成混乱。在 shardingsphere 的 master 分支中，编写集成测试的标准方式是用 testcontainers 启动 docker 镜像。希望有 kingbase 开发人员可以澄清这一点。
At present, the testcontainers official website does not integrate Kingbase, which means that this feature cannot be added at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on issue #33628:
URL: https://github.com/apache/shardingsphere/issues/33628#issuecomment-2469977389
- The core problem is that developers need a legal docker image for testing. Opengauss does not have an integrated module for testcontainers java, but the binary files of the docker image of `opengauss/opengauss:5.0.0` are standard gpl v3 licenses, and ASF does not restrict the use of copyleft and EULA in the build process and unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "wh-zxt-01 (via GitHub)" <gi...@apache.org>.
wh-zxt-01 commented on issue #33628:
URL: https://github.com/apache/shardingsphere/issues/33628#issuecomment-2469904548
There is a trial version available for download on its official website, or you can ask its sales staff for it. However, upon checking in the Docker Hub central repository, it was found to be privately created and no official image was found @linghengqian
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on issue #33628:
URL: https://github.com/apache/shardingsphere/issues/33628#issuecomment-2469863626
- If there is no kingbase docker image that is free to use, then I would say it is impossible. Testcontainers java does not have a kingbase integration module.
- You will probably have to implement kingbase dialect parsing in downstream projects yourself.
- Or feel free to leave your views to push your PR, like db2 and microsoft sql server teams took initiative to create testcontainers java integration module and clarify legal issues. Docker images like Vertica CE require a paid license to perform unit tests, and creating integration tests for such databases is a direct violation of the law.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on issue #33628:
URL: https://github.com/apache/shardingsphere/issues/33628#issuecomment-2469925277
- As a developer who has never touched kingbase, I don't think legal discussions should happen in private mail threads. I think kingbase developers should clarify whether there is a docker image without legal issues, just like the IBM employee in https://github.com/testcontainers/testcontainers-java/issues/2496#issuecomment-610402944 .
- Otherwise, the current issue seems meaningless.
- There is indeed no legal problem in creating sql parsing modules, the problem is how other shardingsphere developers can legally test these modules. If other developers cannot legally write integration tests, it will definitely cause confusion in the future. In the master branch of shardingsphere, the standard way to write integration tests is to start the docker image with testcontainers. I hope a kingbase developer can clarify this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "wh-zxt-01 (via GitHub)" <gi...@apache.org>.
wh-zxt-01 commented on issue #33628:
URL: https://github.com/apache/shardingsphere/issues/33628#issuecomment-2469967823
At present, the testcontainers official website does not integrate Kingbase, which means that this feature cannot be added at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "wh-zxt-01 (via GitHub)" <gi...@apache.org>.
wh-zxt-01 commented on issue #33628:
URL: https://github.com/apache/shardingsphere/issues/33628#issuecomment-2470038459
> * The core problem is that developers need a legal docker image for testing. Opengauss does not have an integrated module for testcontainers java, but the binary files of the docker image of `opengauss/opengauss:5.0.0` are standard gpl v3 licenses, and ASF does not restrict the use of copyleft and EULA in the build process and unit tests.
>Understood, thank you for your answer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "wh-zxt-01 (via GitHub)" <gi...@apache.org>.
wh-zxt-01 closed issue #33628: SQL parser support kingbase
URL: https://github.com/apache/shardingsphere/issues/33628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "wh-zxt-01 (via GitHub)" <gi...@apache.org>.
wh-zxt-01 commented on issue #33628:
URL: https://github.com/apache/shardingsphere/issues/33628#issuecomment-2469906499
If it's just SQL parsing, are there any legal issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] SQL parser support kingbase [shardingsphere]
Posted by "wh-zxt-01 (via GitHub)" <gi...@apache.org>.
wh-zxt-01 closed issue #33628: SQL parser support kingbase
URL: https://github.com/apache/shardingsphere/issues/33628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org