You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/11/01 17:11:29 UTC
[Impala-ASF-CR] IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11845
Change subject: IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
......................................................................
IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Q31: the substitution variables didn't match the TPC-DS spec.
After fixing this, the results match up to 4 digits of
rounding (there is some error introduced in intermediate
calculations).
Q59: the results match the reference results up to rounding.
Q89: the results match up to 5 digits of rounding.
I verified the matches by using a spreadsheet comparing reference
and actual results.
https://docs.google.com/spreadsheets/d/1MNEqkfYRRAd3xqY6m20tTHquqjtCThDaGdizzRAQ8co/edit?usp=sharing
*https://github.com/gregrahn/tpcds-kit/blob/master/specification/TPC-DS_v2.10.0.pdf
^https://github.com/gregrahn/tpcds-kit/tree/master/answer_sets
Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
---
M testdata/workloads/tpcds-unmodified/queries/tpcds-q31.test
M testdata/workloads/tpcds-unmodified/queries/tpcds-q59.test
M testdata/workloads/tpcds-unmodified/queries/tpcds-q89.test
M tests/query_test/test_tpcds_queries.py
4 files changed, 358 insertions(+), 66 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/11845/1
--
To view, visit http://gerrit.cloudera.org:8080/11845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
Gerrit-Change-Number: 11845
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11845 )
Change subject: IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
......................................................................
IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Q31: the substitution variables didn't match the TPC-DS spec.
After fixing this, the results match up to 4 digits of
rounding (there is some error introduced in intermediate
calculations).
Q59: the results match the reference results up to rounding.
Q89: the results match up to 5 digits of rounding.
I verified the matches by using a spreadsheet comparing reference
and actual results.
https://docs.google.com/spreadsheets/d/1MNEqkfYRRAd3xqY6m20tTHquqjtCThDaGdizzRAQ8co/edit?usp=sharing
*https://github.com/gregrahn/tpcds-kit/blob/master/specification/TPC-DS_v2.10.0.pdf
^https://github.com/gregrahn/tpcds-kit/tree/master/answer_sets
Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
Reviewed-on: http://gerrit.cloudera.org:8080/11845
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/tpcds-unmodified/queries/tpcds-q31.test
M testdata/workloads/tpcds-unmodified/queries/tpcds-q59.test
M testdata/workloads/tpcds-unmodified/queries/tpcds-q89.test
M tests/query_test/test_tpcds_queries.py
4 files changed, 358 insertions(+), 66 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
Gerrit-Change-Number: 11845
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11845 )
Change subject: IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
Gerrit-Change-Number: 11845
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Nov 2018 22:11:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11845 )
Change subject: IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1249/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
Gerrit-Change-Number: 11845
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Nov 2018 17:45:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Posted by "Greg Rahn (Code Review)" <ge...@cloudera.org>.
Greg Rahn has posted comments on this change. ( http://gerrit.cloudera.org:8080/11845 )
Change subject: IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
......................................................................
Patch Set 1: Code-Review+2
All three answer files are identical (even in decimal precision) to Netezza so LGTM.
--
To view, visit http://gerrit.cloudera.org:8080/11845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
Gerrit-Change-Number: 11845
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Nov 2018 21:02:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11845 )
Change subject: IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
Gerrit-Change-Number: 11845
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Nov 2018 18:27:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11845 )
Change subject: IMPALA-5946,IMPALA-5956: add TPC-DS q31,q59,q89
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3412/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I49634e8f63066773c9c78dd5585a0ee69daf720a
Gerrit-Change-Number: 11845
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Nov 2018 18:27:52 +0000
Gerrit-HasComments: No