[jira] Commented: (LOG4NET-20) [PATCH] Adds "extends" attribute to appenders

["Ron Grabowski (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/LOG4NET-20?page=comments#action_65680 ]
     
Ron Grabowski commented on LOG4NET-20:
--------------------------------------

Thanks for writing the code Dag. This may not be such a good idea after all. Extending everything means there isn't any way to revert an extended property to its default extension. For example, if I want LogFileAppender to have the default value for MaximumFileSize I can't do that. I may be able to use something like this:

<appender name="LogFileAppender" extends="LogFileAppenderDefaultLayout">
 <param name="File" value="log.txt"/>
 <param name="MaximumFileSize" value="" />
 <param name="MaxSizeRollBackups" value=""/> 
</appender> 

That looks weird and may not be valid. 

One may argue that you shouldn't extend an Appender unless you want _all_ the properties to be extended...

> [PATCH] Adds "extends" attribute to appenders
> ---------------------------------------------
>
>          Key: LOG4NET-20
>          URL: http://issues.apache.org/jira/browse/LOG4NET-20
>      Project: Log4net
>         Type: Improvement
>   Components: Appenders
>     Versions: 1.2.9
>  Environment: WinXP, .NET Framework 1.1
>     Reporter: Dag Christensen
>     Priority: Trivial
>  Attachments: DOMHierarchyConfigurator.patch
>
> Adds "extends" attribute to appenders. Improvement suggested by Ron Grabowski on log4net-user.
> Sample usage:
> <appender name="LogFileAppenderBase" type="log4net.Appender.RollingFileAppender">
> 	<param name="CountDirection" value="1"/>
> 	<param name="AppendToFile" value="true"/>
> 	<param name="MaxSizeRollBackups" value="10"/>
> 	<param name="MaximumFileSize" value="5MB"/>
> 	<param name="RollingStyle" value="Size"/>
> 	<param name="StaticLogFileName" value="true"/>
> </appender>
> <appender name="LogFileAppenderDefaultLayout" extends="LogFileAppenderBase">
> 	<layout type="log4net.Layout.PatternLayout">
> 		<param name="ConversionPattern" value="%d{dd.MM.yy HH:mm:ss} [%t] %-5p %c{1} %m [%x]%n"/>
> 	</layout>
> </appender>
> <appender name="LogFileAppender" extends="LogFileAppenderDefaultLayout">
> 	<param name="File" value="log.txt"/>
> </appender>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira