svn commit: r1181487 - /hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java

[ns...@apache.org]

Author: nspiegelberg
Date: Tue Oct 11 02:12:44 2011
New Revision: 1181487

URL: http://svn.apache.org/viewvc?rev=1181487&view=rev
Log:
counters for slow RPC requests

Summary:
We should be tracking in OpenTSDB data for slow requests.

Test Plan:
These metrics show up on my test cluster as for example:

"hadoop.regionserver_rpc_multiput.aboveonesec.avgtime": 1341,
"hadoop.regionserver_rpc_multiput.aboveonesec.maxtime": 3728,
"hadoop.regionserver_rpc_multiput.aboveonesec.mintime": 1005,
"hadoop.regionserver_rpc_multiput.aboveonesec.numops": 12,

Differential Revision: 213848
Reviewed By: nspiegelberg
Reviewers: nspiegelberg
CC: nspiegelberg, hbase@lists
Revert Plan:
OK

Modified:
    hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java

Modified: hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java?rev=1181487&r1=1181486&r2=1181487&view=diff
==============================================================================
--- hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java (original)
+++ hbase/branches/0.89/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java Tue Oct 11 02:12:44 2011
@@ -593,6 +593,10 @@ public class HBaseRPC {
         rpcMetrics.rpcQueueTime.inc(qTime);
         rpcMetrics.rpcProcessingTime.inc(processingTime);
         rpcMetrics.inc(call.getMethodName(), processingTime);
+        if (processingTime > 1000) {
+          rpcMetrics.inc(call.getMethodName() + ".aboveOneSec.",
+                         processingTime);
+        }
         if (verbose) log("Return: "+value);
 
         return new HbaseObjectWritable(method.getReturnType(), value);