You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/23 02:09:06 UTC

[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #1608: Add `substring` support for binary

HaoYang670 commented on code in PR #1608:
URL: https://github.com/apache/arrow-rs/pull/1608#discussion_r856778546


##########
arrow/src/compute/kernels/substring.rs:
##########
@@ -291,11 +575,14 @@ mod tests {
 
         cases.into_iter().try_for_each::<_, Result<()>>(
             |(array, start, length, expected)| {
-                let array = StringArray::from(array);

Review Comment:
   We did not cover `LargeStringArray` in the past. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org