You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/26 08:55:21 UTC

[GitHub] [inlong] lucaspeng12138 opened a new pull request, #6023: [INLONG-6022][Agent] Fix lost read and send count

lucaspeng12138 opened a new pull request, #6023:
URL: https://github.com/apache/inlong/pull/6023

   ### Prepare a Pull Request
   
   Fix lost read and send count
   - Fixes #6022 
   
   ### Motivation
   
   Fix lost read and send count
   
   ### Modifications
   
   Fix lost read and send count
   
   ### Verifying this change
   
   Fix lost read and send count


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #6023: [INLONG-6022][Agent] Fix lost read and send count

Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6023:
URL: https://github.com/apache/inlong/pull/6023


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] pocozh commented on a diff in pull request #6023: [INLONG-6022][Agent] Fix lost read and send count

Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #6023:
URL: https://github.com/apache/inlong/pull/6023#discussion_r979762838


##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/SenderManager.java:
##########
@@ -264,11 +265,13 @@ public void sendBatchSync(String groupId, String streamId,
             if (result == SendResult.OK) {

Review Comment:
   If `pluginSendCount` includes success and fail, is it better to add it just after doing send operation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org