[GitHub] [pinot] Jackie-Jiang commented on issue #10697: double NaN as default value can massivly expand off heap mutable dictionary

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on issue #10697:
URL: https://github.com/apache/pinot/issues/10697#issuecomment-1728675910

   I feel we should just reject `NaN` for now. Dictionary binary search might also fail.
   To reject it, we can add a check in `FieldSpec.getDefaultNullValue()`, and in the record reader, replace `NaN` with the default value. @jvenant Do you want to help contribute this?
   
   cc @snleee


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org