You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/03/10 10:33:09 UTC

[GitHub] [kafka] kowshik commented on pull request #11815: MINOR: Eliminate FileRecords mutable flag

kowshik commented on pull request #11815:
URL: https://github.com/apache/kafka/pull/11815#issuecomment-1063904350


   @junrao Thanks for catching. I found the test failures to be valid. Thinking about it agian, now I'm not sure if it is feasible to proceed with eliminating the `mutable` flag, because it appears to be used actively. For ex: there is code in `FileRawSnapshotWriter` which sets the file to read-only mode, ex: https://github.com/apache/kafka/blob/0f00f36/raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java#L113. As a result, `FileRawSnapshotReader` can open the file only in read mode, and therefore it needs to pass `mutable=false` to `FileRecords.open()`. Most of the test failures are due to this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org