You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rmetzger <gi...@git.apache.org> on 2015/08/30 13:22:52 UTC
[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1076
[FLINK-2584] Check for unshaded classes in fat jar and shade curator
This PR is an addition for FLINK-2584, removing the transitive guava dependencies from the fat jar introduced by Apache Curator.
Its also adding a check ensuring that shaded classes (guava, asm) are not showing up in the fat jar.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink2584
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1076.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1076
----
commit 7ae0c9d956ffcdb77d55edc70f1588dc507a9c39
Author: Robert Metzger <rm...@apache.org>
Date: 2015-08-27T16:13:08Z
[FLINK-2584] Check for unshaded classes in fat jar and shade curator
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1076#issuecomment-136131254
Nice work :) This needs to go into the milestone branch as well.
What do you mean with "We can easily integrate curator's netty into the jar file."?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1076#issuecomment-136336944
I'll merge this now into `master` and `0.10.0-milestone1`.
In the long run, we can hopefully convince curator to offer a shaded version in addition to the unshaded version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1076#issuecomment-136339437
Make sure it does not break with @tillrohrmann's recent merge ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2584] Check for unshaded classes in fat...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1076#issuecomment-136131482
I saw that curator has a netty dependency.
If we are running into netty conflicts because of curator's netty dependency, it's very easy to just shade curator's netty into curator.
My change is creating a new apache curator jar for us, where guava is located in `org.apache.curator.shaded.com.google`. We can do exactly the same for netty if needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---