You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/08/27 08:47:08 UTC
[jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Not all S3-compatible providers support virtual host buckets and thus
we should disable this feature by default. Continue to enable virtual
host buckets for AWS-S3 which supports this although this feature
suffers from DNS settling issues.
You can merge this Pull Request by running:
git pull https://github.com/maginatics/jclouds disable-s3-virtual-host-bucket
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/131
-- Commit Summary --
* Disable S3 virtual host buckets for generic S3
-- File Changes --
M apis/s3/src/main/java/org/jclouds/s3/S3ApiMetadata.java (2)
M providers/aws-s3/src/main/java/org/jclouds/aws/s3/AWSS3ApiMetadata.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/131.patch
https://github.com/jclouds/jclouds/pull/131.diff
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #430](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/430/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25109827
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Andrew Phillips <no...@github.com>.
Close-n-reopening to trigger BuildHive et al...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25106305
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Andrew Gaul <no...@github.com>.
Fixed unit tests, addressed @adriancole 's override suggestion, and rebased.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25141851
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Adrian Cole <no...@github.com>.
Only comment is that there should be a test left in "s3" that uses virtual host buckets. Maybe testAppendBucketNameInURIPath should be an additional test as opposed to replacing the virtual host one?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25176667
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #351](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/351/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-23319841
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Andrew Phillips <no...@github.com>.
> Maybe testAppendBucketNameInURIPath should be an additional test as opposed to replacing the virtual host one?
Stupid question: Is it possible to set `PROPERTY_S3_VIRTUAL_HOST_BUCKETS` for a single test or would that require an additional test class?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25182749
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #238](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/238/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25143074
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Andrew Phillips <no...@github.com>.
@andrewgaul: Any thoughts/updates on those test failures?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-24473956
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Adrian Cole <no...@github.com>.
commit 06b8cd7ac5420b0e3668bca6116ad5a3a29bbca8
Author: Andrew Gaul <ga...@apache.org>
Date: Mon Aug 26 23:26:15 2013 -0700
JCLOUDS-305. Disable S3 virtual host buckets for generic S3
Not all S3-compatible providers support virtual host buckets and thus
we should disable this feature by default. Continue to enable virtual
host buckets for AWS-S3 which supports this although this feature
suffers from DNS settling issues. Ran ran integration tests against
AWS-S3 and Scality using its S3 API.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25284913
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #699](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/699/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25143210
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #697](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/697/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25110357
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Adrian Cole <no...@github.com>.
will reword the commit when I merge into https://issues.apache.org/jira/browse/JCLOUDS-305
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25284033
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Adrian Cole <no...@github.com>.
it isn't required to be a system property, so yeah. You can set this with ContextBuilder
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25185267
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #639](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/639/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-23317851
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #236](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/236/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25110513
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Adrian Cole <no...@github.com>.
I'd remove the property override here, which proves the default works
https://github.com/maginatics/jclouds/blob/0c83688b3378b765e76b8b9b9e61111466a124f5/apis/s3/src/test/java/org/jclouds/s3/S3ClientMockTest.java
otherwise, LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-25102796
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #179](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/179/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-23318154
Re: [jclouds] Disable S3 virtual host buckets for generic S3 (#131)
Posted by Andrew Phillips <no...@github.com>.
Looks like we have some [real](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/351/testReport/) [test failures](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/639/testReport/) here...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/131#issuecomment-23343114