[GitHub] [skywalking-eyes] wu-sheng commented on a change in pull request #1: Styles-based comments, license files, tests

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #1:
URL: https://github.com/apache/skywalking-eyes/pull/1#discussion_r546766519



##########
File path: LICENSE
##########
@@ -199,3 +199,21 @@
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
+
+
+=======================================================================
+Apache SkyWalking Eyes Subcomponents:
+
+The Apache SkyWalking Eyes project contains subcomponents with separate copyright
+notices and license terms. Your use of the source code for the these
+subcomponents is subject to the terms and conditions of the following
+licenses.
+
+========================================================================
+MIT licenses
+========================================================================
+
+The following components are provided under the MIT license. See project link for details.
+The text of each license is also included at licenses/LICENSE-[project].txt.
+
+    languages.yaml from GitHub: https://github.com/github/linguist/blob/master/lib/linguist/languages.yml MIT

Review comment:
       From the license's perspective, I think it is fine. About the paper work, I think you miss `licenses/LICENSE-linguist.txt`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org