[I] Go SDK: add GetMe [iggy]

["justinmclean (via GitHub)" <gi...@apache.org>]

justinmclean opened a new issue, #4368:
URL: https://github.com/apache/iggy/issues/4368

   The Rust client has `SystemClient::get_me` (`core/common/src/traits/system_client.rs`), which returns the details of the calling client. The Go SDK defines the command code, `GetMeCode` in `foreign/go/internal/command/code.go`, but has no command or client method for it. The end-to-end tests send the raw code instead.
   
   ## What to do
   
   - Add a `GetMe` command to `foreign/go/internal/command/system.go`, following `GetStats`: `Code()` returns `GetMeCode` and `MarshalBinary()` returns an empty payload.
   - Add `GetMe(ctx context.Context) (*ClientInfoDetails, error)` to the `Client` interface in `foreign/go/contracts/client.go`, next to `GetClient`.
   - Implement it in `foreign/go/client/tcp/tcp_clients_management.go`, following `GetClient`. The reply has the same layout, so `binaryserialization.DeserializeClient` decodes it.
   - Add `GetMe` to `TestEmptySystemCommandBodies` in `foreign/go/internal/command/system_test.go`.
   - Replace the raw `SendBinaryRequest(ctx, uint32(command.GetMeCode), nil)` calls in `foreign/go/tests/e2e_test.go` with `GetMe`.
   
   ## Done when
   
   `client.GetMe(ctx)` returns the calling client's details against a running server, and the tests pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Go SDK: add GetMe [iggy]

["hubcio (via GitHub)" <gi...@apache.org>]

hubcio closed issue #4368: Go SDK: add GetMe
URL: https://github.com/apache/iggy/issues/4368


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Go SDK: add GetMe [iggy]

["xiaozou-wine (via GitHub)" <gi...@apache.org>]

xiaozou-wine commented on issue #4368:
URL: https://github.com/apache/iggy/issues/4368#issuecomment-5923554608

   I'd like to work on this.
   
   I have a local implementation ready: a `GetMe` command mirroring `GetStats`, the `Client` interface method next to `GetClient`, the TCP client call via `DeserializeClient`, and the four `tests/e2e_test.go` replacements. Verified locally with `go build`, `go vet`, `gofmt`, the unit tests, and the e2e suite against a running server.
   
   One note on the e2e suite: `TestE2E_SplitPrimaryManualCommitPreservesMembership` already fails on master, before any of my changes — the failure is in `StoreConsumerOffset`, not in `GetMe`. I confirmed this by stashing my changes and re-running the fixture against unmodified code, which reproduces the same error. The auto-commit split-primary case passes.
   
   Happy to open a PR once the approach is agreed and the issue is assigned.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Go SDK: add GetMe [iggy]

["hubcio (via GitHub)" <gi...@apache.org>]

hubcio commented on issue #4368:
URL: https://github.com/apache/iggy/issues/4368#issuecomment-5927183248

   @xiaozou-wine assigned
   	


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org