You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org> on 2019/12/09 09:58:11 UTC

[kudu-CR] [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)

Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, Greg Solovyev, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14427

to look at the new patch set (#9).

Change subject: [KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)
......................................................................

[KUDU-2632] Add a DATE type backed by INT32 (Part 1, C++ client)

This adds a new DATE type, represented by an INT32 and
that should store the number of days from the Unix epoch, January 1,
1970.
Range:
0001-01-01 to 9999-12-31
or
-719162 to 2932896 (days; computed with mktime()/(24*60*60),
timezone = GMT, daylight saving = 0)
Range validation is done in KuduPartialRow::SetDate() function.

Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986
---
M src/kudu/client/client-unittest.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/client/value.cc
M src/kudu/common/common.proto
M src/kudu/common/key_util.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
M src/kudu/common/partition.cc
M src/kudu/common/row.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/common/types.h
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/integration-tests/all_types-itest.cc
M src/kudu/integration-tests/data_gen_util.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_perf.cc
M src/kudu/tools/tool_action_table.cc
24 files changed, 223 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/14427/9
-- 
To view, visit http://gerrit.cloudera.org:8080/14427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d803b6eb573a0b36c99c5a2012f12319a548986
Gerrit-Change-Number: 14427
Gerrit-PatchSet: 9
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>