You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/12/19 15:12:51 UTC
[GitHub] [skywalking-query-protocol] wu-sheng opened a new pull request #65: Enhance layer definition of service.
wu-sheng opened a new pull request #65:
URL: https://github.com/apache/skywalking-query-protocol/pull/65
1. Add layer ID for service ID encoding. `service name` + `layer` is the unique key for a service.
2. One service name could be multiple layers
3. Add layer definition for service instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] kezhenxu94 commented on a change in pull request #65: Enhance layer definition of service.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #65:
URL: https://github.com/apache/skywalking-query-protocol/pull/65#discussion_r771967789
##########
File path: metadata-v2.graphqls
##########
@@ -22,27 +22,31 @@
# Service is a logic concept, representing a collection of runnable context.
type Service {
+ # Service ID = BASE64(name) + '.' + Layer ID
id: ID!
name: String!
# The custom/logi group of the service
group: String!
# Layer represents an abstract framework in the computer science, such as operation system(VM layer), Kubernetes(k8s layer),
# Service Mesh(typical Istio+Envoy layer).
- # The name of layer is a string, but we would reserve some for visualization(UI)
- # - os-linux
- # - k8s
- # - general(agent-installed)
- # - faas
- # - mesh
- # - mesh-cp
- # - mesh-dp
- # - database
- # - cache
- # - browser
- # - skywalking
+ # The name of layer is a string, but we would reserve the following for visualization(UI)
+ # - ID: 0, NAME: undefined
+ # - ID: 1, NAME: mesh
+ # - ID: 2, NAME: general(agent-installed)
+ # - ID: 3, NAME: os-linux
+ # - ID: 4, NAME: k8s
+ # - ID: 5, NAME: faas
+ # - ID: 6, NAME: mesh-cp
+ # - ID: 7, NAME: mesh-dp
+ # - ID: 8, NAME: database
+ # - ID: 9, NAME: cache
+ # - ID: 10, NAME: browser
+ # - ID: 11, NAME: skywalking
#
- # UI uses this literal string names to provide various layout for their services with metrics.
- layer: String!
+ # UI uses this literal layer names to provide various layout for their services with metrics.
+ #
+ # The layer collection is from the instances of this service. So, one service could have multiple layer due to instance-level registration.
+ layer: [String!]!
Review comment:
What about using `layers`?
##########
File path: metadata-v2.graphqls
##########
@@ -22,27 +22,31 @@
# Service is a logic concept, representing a collection of runnable context.
type Service {
+ # Service ID = BASE64(name) + '.' + Layer ID
Review comment:
Now this is totally incompatible right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng merged pull request #65: Enhance layer definition of service.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #65:
URL: https://github.com/apache/skywalking-query-protocol/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #65: Enhance layer definition of service.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #65:
URL: https://github.com/apache/skywalking-query-protocol/pull/65#discussion_r771968036
##########
File path: metadata-v2.graphqls
##########
@@ -22,27 +22,31 @@
# Service is a logic concept, representing a collection of runnable context.
type Service {
+ # Service ID = BASE64(name) + '.' + Layer ID
id: ID!
name: String!
# The custom/logi group of the service
group: String!
# Layer represents an abstract framework in the computer science, such as operation system(VM layer), Kubernetes(k8s layer),
# Service Mesh(typical Istio+Envoy layer).
- # The name of layer is a string, but we would reserve some for visualization(UI)
- # - os-linux
- # - k8s
- # - general(agent-installed)
- # - faas
- # - mesh
- # - mesh-cp
- # - mesh-dp
- # - database
- # - cache
- # - browser
- # - skywalking
+ # The name of layer is a string, but we would reserve the following for visualization(UI)
+ # - ID: 0, NAME: undefined
+ # - ID: 1, NAME: mesh
+ # - ID: 2, NAME: general(agent-installed)
+ # - ID: 3, NAME: os-linux
+ # - ID: 4, NAME: k8s
+ # - ID: 5, NAME: faas
+ # - ID: 6, NAME: mesh-cp
+ # - ID: 7, NAME: mesh-dp
+ # - ID: 8, NAME: database
+ # - ID: 9, NAME: cache
+ # - ID: 10, NAME: browser
+ # - ID: 11, NAME: skywalking
#
- # UI uses this literal string names to provide various layout for their services with metrics.
- layer: String!
+ # UI uses this literal layer names to provide various layout for their services with metrics.
+ #
+ # The layer collection is from the instances of this service. So, one service could have multiple layer due to instance-level registration.
+ layer: [String!]!
Review comment:
Yes. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #65: Enhance layer definition of service.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #65:
URL: https://github.com/apache/skywalking-query-protocol/pull/65#discussion_r771967983
##########
File path: metadata-v2.graphqls
##########
@@ -22,27 +22,31 @@
# Service is a logic concept, representing a collection of runnable context.
type Service {
+ # Service ID = BASE64(name) + '.' + Layer ID
Review comment:
For existing data, yes, it isn't. Because one way or another, we need layer definition for service to visualize in the booster UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org