[GitHub] [doris] yiguolei commented on a diff in pull request #12160: [feature](light-schema-change) fix light-schema-change and add more cases

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #12160:
URL: https://github.com/apache/doris/pull/12160#discussion_r958079935


##########
be/src/vec/olap/block_reader.cpp:
##########
@@ -283,8 +283,7 @@ Status BlockReader::_unique_key_next_block(Block* block, MemPool* mem_pool, Obje
 
     // do filter detete row in base compaction, only base compaction need to do the job
     if (_filter_delete) {
-        int delete_sign_idx =
-                (_sequence_col_idx == -1) ? target_columns.size() - 1 : target_columns.size() - 2;

Review Comment:
   should also modify non-vectorized engine's code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org