You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by wwb <gi...@git.apache.org> on 2016/12/19 02:19:46 UTC
[GitHub] lucenenet pull request #200: Adding nunit 3 console package to enable TeamCi...
GitHub user wwb opened a pull request:
https://github.com/apache/lucenenet/pull/200
Adding nunit 3 console package to enable TeamCity to run the tests.
Adding Nunit 3 console package to enable TeamCity to run the nunit 3.5 tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wwb/lucenenet nunit-console
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit 6b450490d01f78287d9eee18e79f81736bfdeac5
Author: wwb <gi...@wyattbarnett.net>
Date: 2016-12-19T02:18:04Z
Adding nunit 3 console package to enable TeamCity to run the tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #200: Adding nunit 3 console package to enable TeamCity to r...
Posted by NightOwl888 <gi...@git.apache.org>.
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/200
> It would be cool to get #191 merged so we can get TeamCity working with the new layout, not sure what is between us and that though.
I know there is at least:
- Tests that are failing/running infinitely over there that are not here
- Working out what to do about the build/TeamCity. The build script is setup to run the build for the entire solution at once. But you seem to be running one project at a time (at least for testing). Is there any reason we can't just hook into a single build script that does the build? Or should we aim to make the build script work at the project level?
It looks like @conniey already setup a TeamCity task to run the build once we get over there, but I am still unsure it can accept our current versioning scheme (which I have confirmed will do the trick and I think we should keep).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #200: Adding nunit 3 console package to enable TeamCity to r...
Posted by wwb <gi...@git.apache.org>.
Github user wwb commented on the issue:
https://github.com/apache/lucenenet/pull/200
Yes -- this is to keep TeamCity running with that in play. You can reject this one and revert that.
It would be cool to get #191 merged so we can get TeamCity working with the new layout, not sure what is between us and that though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #200: Adding nunit 3 console package to enable TeamCity to r...
Posted by wwb <gi...@git.apache.org>.
Github user wwb commented on the issue:
https://github.com/apache/lucenenet/pull/200
If you are talking about [this one] (https://teamcity.jetbrains.com/viewType.html?buildTypeId=LuceneNet_Vs2015LuceneNetPortable) -- I set that one up to wrap my head around what needed to change to run the new version of the project. It still isn't quite perfect but it is getting there. Currently I am using build.ps1 to build things. I am still working on getting the tests to run successfully. It can easily be made to accept the current versioning once we unify the codebase.
The individual project builds and tests are at @synhershko 's request. Mechanically, the [Lucene.net.core](https://teamcity.jetbrains.com/viewType.html?buildTypeId=LuceneNet_Core) build is the real build and test with the nightly generating the myget packages. At the end of the day the build system has to take into account that we want individual packages for the sub-projects.
In terms of a path forward I suggest that we just get a clean build up with the core things in place and then fix the tests -- as well as build out nuget packaging. How we want to build it changes based on the new structure so we might as well get that in place and build on top of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #200: Adding nunit 3 console package to enable TeamCity to r...
Posted by NightOwl888 <gi...@git.apache.org>.
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/200
Hi, does this have anything to do with #194? We should probably revert that change, since it causes a conflict with #191 (which we are actively working on).
We really should be working off of #191 only at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request #200: Adding nunit 3 console package to enable TeamCi...
Posted by wwb <gi...@git.apache.org>.
Github user wwb closed the pull request at:
https://github.com/apache/lucenenet/pull/200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---