You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/03 23:35:13 UTC
[GitHub] [arrow] edponce commented on a change in pull request #12060: ARROW-15216: [GLib] Add Arrow::RoundToMultipleOptions
edponce commented on a change in pull request #12060:
URL: https://github.com/apache/arrow/pull/12060#discussion_r777754242
##########
File path: c_glib/arrow-glib/compute.cpp
##########
@@ -3136,6 +3142,179 @@ garrow_round_options_new(void)
}
+typedef struct GArrowRoundToMultipleOptionsPrivate_ {
+ GArrowScalar *multiple;
+} GArrowRoundToMultipleOptionsPrivate;
+
+enum {
+ PROP_ROUND_TO_MULTIPLE_OPTIONS_MULTIPLE = 1,
+ PROP_ROUND_TO_MULTIPLE_OPTIONS_MODE,
+};
+
+G_DEFINE_TYPE_WITH_PRIVATE(GArrowRoundToMultipleOptions,
+ garrow_round_to_multiple_options,
+ GARROW_TYPE_FUNCTION_OPTIONS)
Review comment:
I am curious why their is a GLib difference between the [implementation of `Arrow::RoundOptions`](https://github.com/apache/arrow/pull/12043/files#diff-c104a8d72db70ce577a9cf0666ab8cf1d541648a11c8c98751ee3064fd254a28R2910) and `Arrow::RoundToMultipleOptions`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org