You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/14 17:17:40 UTC
[GitHub] [airflow] RaviTezu opened a new pull request #11528: Add upgrade rule to check for mesos config and flag to remove it.
RaviTezu opened a new pull request #11528:
URL: https://github.com/apache/airflow/pull/11528
closes: #11043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-716137579
@turbaszek Pulled (with --rebase) commits from `v1-10-test` into my branch and then changed the base to `v1-10-stable`. There was a merge conflict and I resolved it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-721045383
Linked to #11391
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-713418950
@mik-laj can you please take a look at CI? This look like a problem with building docs - but not related to the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11528: Add upgrade rule to check for mesos config and flag to remove it.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-708542313
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil removed a comment on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
kaxil removed a comment on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-721445539
Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
It will help if your squash your commits into single commit first so that there are less conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-731240879
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-717406923
Thank you @turbaszek
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #11528: Add upgrade rule to check for mesos config and flag to remove it.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r504948588
##########
File path: airflow/upgrade/rules/mesos_executor_removed.py
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.configuration import conf
+
+
+class MesosExecutorRemovedRule(BaseRule):
+ """
+ MesosExecutorRemovedRule class to ease upgrade to Airflow 2.0
+ """
+
+ title = "Removal of Mesos Executor"
+ description = """
+ The Mesos Executor has been deprecated as it was not widely used and not maintained.
+ """
+
+ def check(self):
+ mesos_config = conf.getsection("mesos")
Review comment:
The existence of this section in the configuration file does not prevent migration to Airflow 2.0. I think we should check that the `executor` option in the `core` section is not set to `MesosExecutor` and warn the user that he needs to migrate to another supported alternative such as CeleryExecutor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman merged pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #11528:
URL: https://github.com/apache/airflow/pull/11528
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-721445539
Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
It will help if your squash your commits into single commit first so that there are less conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-716125212
@RaviTezu would you mind rebasing and changing the target base due to https://github.com/apache/airflow/pull/11719#issuecomment-714258732
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-717361173
@RaviTezu I cleaned up the PR, once the CI is green I will merge it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on a change in pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r508012868
##########
File path: airflow/upgrade/rules/mesos_executor_removed.py
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.configuration import conf
+
+
+class MesosExecutorRemovedRule(BaseRule):
+ """
+ MesosExecutorRemovedRule class to ease upgrade to Airflow 2.0
+ """
+
+ title = "Removal of Mesos Executor"
+ description = """
+ The Mesos Executor has been deprecated as it was not widely used and not maintained.
Review comment:
Thanks for the reply @turbaszek. Pushed the changes. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-714912268
@mik-laj Could you please check this PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on a change in pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r509012672
##########
File path: airflow/upgrade/rules/mesos_executor_removed.py
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.configuration import conf
+
+
+class MesosExecutorRemovedRule(BaseRule):
+ """
+ MesosExecutorRemovedRule class to ease upgrade to Airflow 2.0
+ """
+
+ title = "Removal of Mesos Executor"
+ description = """
+ The Mesos Executor has been deprecated as it was not widely used and not maintained.
Review comment:
@turbaszek @mik-laj Can we go ahead and merge this PR? Let me know if you need anything else on this. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r507998470
##########
File path: airflow/upgrade/rules/mesos_executor_removed.py
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.configuration import conf
+
+
+class MesosExecutorRemovedRule(BaseRule):
+ """
+ MesosExecutorRemovedRule class to ease upgrade to Airflow 2.0
+ """
+
+ title = "Removal of Mesos Executor"
+ description = """
+ The Mesos Executor has been deprecated as it was not widely used and not maintained.
Review comment:
Please remove the leading new line and indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-712406278
[The Workflow run](https://github.com/apache/airflow/actions/runs/316218002) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-716162514
@turbaszek No worries. Rebased and forced pushed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11528: Add upgrade rule to check for mesos config and flag to remove it.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-708574767
[The Workflow run](https://github.com/apache/airflow/actions/runs/307055729) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on a change in pull request #11528: Add upgrade rule to check for mesos config and flag to remove it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r505146607
##########
File path: airflow/upgrade/rules/mesos_executor_removed.py
##########
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.configuration import conf
+
+
+class MesosExecutorRemovedRule(BaseRule):
+ """
+ MesosExecutorRemovedRule class to ease upgrade to Airflow 2.0
+ """
+
+ title = "Removal of Mesos Executor"
+ description = """
+ The Mesos Executor has been deprecated as it was not widely used and not maintained.
+ """
+
+ def check(self):
+ mesos_config = conf.getsection("mesos")
Review comment:
Thanks for the reply @mik-laj I will make the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on a change in pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r508012868
##########
File path: airflow/upgrade/rules/mesos_executor_removed.py
##########
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.upgrade.rules.base_rule import BaseRule
+from airflow.configuration import conf
+
+
+class MesosExecutorRemovedRule(BaseRule):
+ """
+ MesosExecutorRemovedRule class to ease upgrade to Airflow 2.0
+ """
+
+ title = "Removal of Mesos Executor"
+ description = """
+ The Mesos Executor has been deprecated as it was not widely used and not maintained.
Review comment:
Thanks for the reply @turbaszek. Pushed the changes. Please take a look.
@mik-laj FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu edited a comment on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu edited a comment on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-716162514
@turbaszek No worries. Rebased and force pushed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-716152114
@RaviTezu sorry for not being clear, you should not only change the target for `v1-10-stable` but also rebase on this branch. Sorry for inconvenience
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-717906051
@turbaszek I looked at the failing checks and they seem to be either the CI/CD system related issues or some other test seems to be failing.
**build errors:**
```
{"success":false,"error":400,"message":"Trouble uploading file"}###########################################################################################
EXITING /opt/airflow/scripts/ci/in_container/run_ci_tests.sh WITH STATUS CODE 1
```
**Tests failing:**
```
test_scheduler_run_duration
tests/executors/test_dask_executor.py::DaskExecutorTest::test_backfill_integration
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu edited a comment on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu edited a comment on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-708940977
@mik-laj @turbaszek Could you please take a look? Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-708940977
@mik-laj Could you please take a look now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu edited a comment on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu edited a comment on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-708940977
@mik-laj @turbaszek Could you please take a look now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] RaviTezu commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
RaviTezu commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-716688599
@turbaszek If this looks good to you. Could you please merge the PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-712406207
[The Workflow run](https://github.com/apache/airflow/actions/runs/316217834) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org