[jira] [Work logged] (LANG-1504) StopWatch: steps feature

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LANG-1504?focusedWorklogId=468359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468359 ]

ASF GitHub Bot logged work on LANG-1504:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/20 01:00
            Start Date: 10/Aug/20 01:00
    Worklog Time Spent: 10m 
      Work Description: topera commented on a change in pull request #482:
URL: https://github.com/apache/commons-lang/pull/482#discussion_r467651878



##########
File path: src/main/java/org/apache/commons/lang3/time/StopWatch.java
##########
@@ -606,4 +681,175 @@ public void unsplit() {
         this.splitState = SplitState.UNSPLIT;
     }
 
+    /**
+     * Stops the watch and returns the list of splits with duration on each split
+     * @return list of splits
+     */
+    public List<Split> getProcessedSplits() {
+        return getProcessedSplits(false);
+    }
+
+    /**
+     * Stops the watch and returns the list of splits with duration on each split (using milliseconds)
+     * @return list of splits
+     */
+    public List<Split> getNanoProcessedSplits() {
+        return getProcessedSplits(true);
+    }
+
+    /**
+     * Stops the watch and returns the list of splits with duration on each split
+     *
+     * @param useNanos if must use nanoseconds precision
+     * @return list of splits
+     */
+    public List<Split> getProcessedSplits(boolean useNanos) {

Review comment:
       Good idea, since it makes the code more clear. I'll change here. Thank you!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 468359)
    Time Spent: 2h 50m  (was: 2h 40m)

> StopWatch: steps feature
> ------------------------
>
>                 Key: LANG-1504
>                 URL: https://issues.apache.org/jira/browse/LANG-1504
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.time.*
>            Reporter: Topera
>            Priority: Major
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Would be great if we could use StopWatch to track times on many places of our code.
> I created a new feature called "*steps*". 
>  
> With this feature we can add label to each step and then get a report with time between each step.
>  
> Example:
> {code:java}
> final StopWatch watch = new StopWatch();
> watch.step("starting");
> exampleGoSleep();
> watch.step("sleeping");
> exampleGoWalk();
> watch.step("walking ");
> exampleGoDance();
> watch.step("dancing ");
> System.out.println(watch.getStepsReport());
> {code}
> The output would be:
> {noformat}
> [starting] 0ms
> [sleeping] 235ms
> [walking ] 20ms
> [dancing ] 458ms
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)