You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Xiaodong DENG (JIRA)" <ji...@apache.org> on 2018/08/20 09:38:00 UTC

[jira] [Updated] (AIRFLOW-2921) A trivial incorrectness in CeleryExecutor()

     [ https://issues.apache.org/jira/browse/AIRFLOW-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiaodong DENG updated AIRFLOW-2921:
-----------------------------------
    Priority: Trivial  (was: Minor)

> A trivial incorrectness in CeleryExecutor()
> -------------------------------------------
>
>                 Key: AIRFLOW-2921
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2921
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Trivial
>
> Code: [https://github.com/apache/incubator-airflow/blob/62bd68999bade4261daf0499b56098d2e6fc9470/airflow/executors/celery_executor.py#L108]
> The logic here is: if a task state becomes either SUCCESS or FAILURE or REVOKED, it will be removed from *self.tasks()* and *self.last_state()*. However, because line108 is not indented properly, this task will be added back to *self.last_state()* again.
> This will not lead to any error. But may still be worth changing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)