You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Stefan Zoerner (JIRA)" <ji...@apache.org> on 2007/05/01 20:45:15 UTC
[jira] Created: (DIRSTUDIO-93) Add server detection for ApacheDS
and TivoliDS on RootDSE property page
Add server detection for ApacheDS and TivoliDS on RootDSE property page
-----------------------------------------------------------------------
Key: DIRSTUDIO-93
URL: https://issues.apache.org/jira/browse/DIRSTUDIO-93
Project: Directory LDAP Studio
Issue Type: Improvement
Components: ldapstudio-browser
Affects Versions: 0.7.0
Reporter: Stefan Zoerner
Priority: Minor
Currently, the property page for the RootDSE does not correctly detects ApacheDS. I have added a conditional for this, and for Tivoli Directory Server (IBM) as well.The method createContents gets longer and longer; thus I have created some detection methods. Feel free to consider the following patch.
>From my point of view, a cleaner and more extensible solution would be to an interface for server detection, which solely operates on the RootDSE attributes. Implementations would be easier to test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-93) Add server detection for ApacheDS
and TivoliDS on RootDSE property page
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre-Arnaud Marcelot updated DIRSTUDIO-93:
--------------------------------------------
Fix Version/s: 0.9.0
> Add server detection for ApacheDS and TivoliDS on RootDSE property page
> -----------------------------------------------------------------------
>
> Key: DIRSTUDIO-93
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-93
> Project: Directory LDAP Studio
> Issue Type: Improvement
> Components: ldapstudio-browser
> Affects Versions: 0.7.0
> Reporter: Stefan Zoerner
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: patch.txt
>
>
> Currently, the property page for the RootDSE does not correctly detects ApacheDS. I have added a conditional for this, and for Tivoli Directory Server (IBM) as well.The method createContents gets longer and longer; thus I have created some detection methods. Feel free to consider the following patch.
> From my point of view, a cleaner and more extensible solution would be to an interface for server detection, which solely operates on the RootDSE attributes. Implementations would be easier to test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DIRSTUDIO-93) Add server detection for ApacheDS and
TivoliDS on RootDSE property page
Posted by "Stefan Zoerner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Zoerner closed DIRSTUDIO-93.
-----------------------------------
Resolution: Fixed
Detection works for the two relevant servers now.
> Add server detection for ApacheDS and TivoliDS on RootDSE property page
> -----------------------------------------------------------------------
>
> Key: DIRSTUDIO-93
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-93
> Project: Directory LDAP Studio
> Issue Type: Improvement
> Components: ldapstudio-browser
> Affects Versions: 0.7.0
> Reporter: Stefan Zoerner
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: patch.txt
>
>
> Currently, the property page for the RootDSE does not correctly detects ApacheDS. I have added a conditional for this, and for Tivoli Directory Server (IBM) as well.The method createContents gets longer and longer; thus I have created some detection methods. Feel free to consider the following patch.
> From my point of view, a cleaner and more extensible solution would be to an interface for server detection, which solely operates on the RootDSE attributes. Implementations would be easier to test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-93) Add server detection for ApacheDS
and TivoliDS on RootDSE property page
Posted by "Pierre-Arnaud Marcelot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pierre-Arnaud Marcelot updated DIRSTUDIO-93:
--------------------------------------------
Fix Version/s: (was: 0.9.0)
1.0.0
> Add server detection for ApacheDS and TivoliDS on RootDSE property page
> -----------------------------------------------------------------------
>
> Key: DIRSTUDIO-93
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-93
> Project: Directory Studio
> Issue Type: Improvement
> Components: studio-browser
> Affects Versions: 0.7.0
> Reporter: Stefan Zoerner
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: patch.txt
>
>
> Currently, the property page for the RootDSE does not correctly detects ApacheDS. I have added a conditional for this, and for Tivoli Directory Server (IBM) as well.The method createContents gets longer and longer; thus I have created some detection methods. Feel free to consider the following patch.
> From my point of view, a cleaner and more extensible solution would be to an interface for server detection, which solely operates on the RootDSE attributes. Implementations would be easier to test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSTUDIO-93) Add server detection for ApacheDS
and TivoliDS on RootDSE property page
Posted by "Stefan Zoerner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Zoerner updated DIRSTUDIO-93:
------------------------------------
Attachment: patch.txt
A patch which contains the server detection for ApacheDS and TivoliDS. Some refactoring has done to keep the method getContents short.
> Add server detection for ApacheDS and TivoliDS on RootDSE property page
> -----------------------------------------------------------------------
>
> Key: DIRSTUDIO-93
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-93
> Project: Directory LDAP Studio
> Issue Type: Improvement
> Components: ldapstudio-browser
> Affects Versions: 0.7.0
> Reporter: Stefan Zoerner
> Priority: Minor
> Attachments: patch.txt
>
>
> Currently, the property page for the RootDSE does not correctly detects ApacheDS. I have added a conditional for this, and for Tivoli Directory Server (IBM) as well.The method createContents gets longer and longer; thus I have created some detection methods. Feel free to consider the following patch.
> From my point of view, a cleaner and more extensible solution would be to an interface for server detection, which solely operates on the RootDSE attributes. Implementations would be easier to test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-93) Add server detection for ApacheDS
and TivoliDS on RootDSE property page
Posted by "Stefan Seelmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492940 ]
Stefan Seelmann commented on DIRSTUDIO-93:
------------------------------------------
Thanks Stefan, I applied the patch: http://svn.apache.org/viewvc?view=rev&rev=534230
You are totally right, the big method isn't very nice. With Eclipse/OSGi it is very easy to realise your suggestion. We could define an Interface and a new eclipse extension point for that. Then new detection code could be plugged-in without changing existing code. A simple interface could look like that:
-------------------------------------------------------------------------
public interface DirectoryTypeDetector
{
/**
* Tries to detect the directory type from the given Root DSE.
*
* @param rootDSE the Root DSE
* @return the directory type or null if not detectable
*/
public String detectDirectoryType( IRootDSE rootDSE );
}
-------------------------------------------------------------------------
Of course there could be some conflicts if more than one registered detector returns a type. But I think we should keep it simple.
> Add server detection for ApacheDS and TivoliDS on RootDSE property page
> -----------------------------------------------------------------------
>
> Key: DIRSTUDIO-93
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-93
> Project: Directory LDAP Studio
> Issue Type: Improvement
> Components: ldapstudio-browser
> Affects Versions: 0.7.0
> Reporter: Stefan Zoerner
> Priority: Minor
> Attachments: patch.txt
>
>
> Currently, the property page for the RootDSE does not correctly detects ApacheDS. I have added a conditional for this, and for Tivoli Directory Server (IBM) as well.The method createContents gets longer and longer; thus I have created some detection methods. Feel free to consider the following patch.
> From my point of view, a cleaner and more extensible solution would be to an interface for server detection, which solely operates on the RootDSE attributes. Implementations would be easier to test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSTUDIO-93) Add server detection for ApacheDS
and TivoliDS on RootDSE property page
Posted by "Stefan Zoerner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSTUDIO-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493459 ]
Stefan Zoerner commented on DIRSTUDIO-93:
-----------------------------------------
Another option would be to create an interface with parameter type javax.naming.directory.Attributes representing the attributes of the Root DSE instead of IRootDSE, because with this the classes would easily used in an arbitrary context, and JUnit test would be easier to create as well.
> Add server detection for ApacheDS and TivoliDS on RootDSE property page
> -----------------------------------------------------------------------
>
> Key: DIRSTUDIO-93
> URL: https://issues.apache.org/jira/browse/DIRSTUDIO-93
> Project: Directory LDAP Studio
> Issue Type: Improvement
> Components: ldapstudio-browser
> Affects Versions: 0.7.0
> Reporter: Stefan Zoerner
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: patch.txt
>
>
> Currently, the property page for the RootDSE does not correctly detects ApacheDS. I have added a conditional for this, and for Tivoli Directory Server (IBM) as well.The method createContents gets longer and longer; thus I have created some detection methods. Feel free to consider the following patch.
> From my point of view, a cleaner and more extensible solution would be to an interface for server detection, which solely operates on the RootDSE attributes. Implementations would be easier to test as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.