You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/17 14:58:12 UTC

[GitHub] [flink] dawidwys opened a new pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

dawidwys opened a new pull request #19135:
URL: https://github.com/apache/flink/pull/19135


   ## What is the purpose of the change
   
   The lifecycle/scope of WatermarkStatus is tightly coupled with watermarks. Upstream watermarks are cut off in the TimestampsAndWatermarksOperator and therefore watermark statuses should be cut off as well.
   
   ## Verifying this change
   
   Added tests in:
   * `TimestampsAndWatermarksOperatorTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys merged pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #19135:
URL: https://github.com/apache/flink/pull/19135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19135:
URL: https://github.com/apache/flink/pull/19135#issuecomment-1070979693


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257",
       "triggerID" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 01f427fccb011deeeb8c7e05d716d9198f234b4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19135:
URL: https://github.com/apache/flink/pull/19135#issuecomment-1070979693


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257",
       "triggerID" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257",
       "triggerID" : "1074975016",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 01f427fccb011deeeb8c7e05d716d9198f234b4d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19135:
URL: https://github.com/apache/flink/pull/19135#issuecomment-1070979693


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257",
       "triggerID" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 01f427fccb011deeeb8c7e05d716d9198f234b4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19135:
URL: https://github.com/apache/flink/pull/19135#issuecomment-1070979693


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 01f427fccb011deeeb8c7e05d716d9198f234b4d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dawidwys commented on pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #19135:
URL: https://github.com/apache/flink/pull/19135#issuecomment-1074975016


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19135:
URL: https://github.com/apache/flink/pull/19135#issuecomment-1070979693


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 01f427fccb011deeeb8c7e05d716d9198f234b4d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19135:
URL: https://github.com/apache/flink/pull/19135#issuecomment-1070979693


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257",
       "triggerID" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257",
       "triggerID" : "1074975016",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 01f427fccb011deeeb8c7e05d716d9198f234b4d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19135: [FLINK-26708] TimestampsAndWatermarksOperator should not propagate WatermarkStatus

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19135:
URL: https://github.com/apache/flink/pull/19135#issuecomment-1070979693


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257",
       "triggerID" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "01f427fccb011deeeb8c7e05d716d9198f234b4d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257",
       "triggerID" : "1074975016",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 01f427fccb011deeeb8c7e05d716d9198f234b4d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33257) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org