You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:26:27 UTC

[GitHub] [systemds] mboehm7 commented on pull request #993: [SYSTEMDS-265] Entity resolution pipelines and primitives.

mboehm7 commented on pull request #993:
URL: https://github.com/apache/systemds/pull/993#issuecomment-665220519


   LGTM - thanks @skogler  and @Iseratho for this substantial new feature. Regarding the example, it's fine to link to the other repo for now, once we make it a builtin function we replace this with a link to the original data along with a script for necessary preprocessing.
   
   During the merge I just made a couple of minor modifications:
   * Vectorized few loops and unnecessary operation sequences, for example: padding for table in preprocessing, and computing the components via outer.
   * Fixed the formatting in all entity resolution tests (tabs over spaces in java code)
   * Fixed a literal replacement rewrite that failed over frame inputs (which resulted from the modified padding). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org