You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 07:51:24 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #22832: Deprecate `DummyOperator` in favor of `EmptyOperator`

eladkal commented on code in PR #22832:
URL: https://github.com/apache/airflow/pull/22832#discussion_r845838167


##########
airflow/models/abstractoperator.py:
##########
@@ -124,7 +124,7 @@ def task_type(self) -> str:
         raise NotImplementedError()
 
     @property
-    def inherits_from_dummy_operator(self) -> bool:
+    def inherits_from_empty_operator(self) -> bool:
         raise NotImplementedError()

Review Comment:
   I thought of that and I'm not 100% sure.
   There isn't a real use for it from users side
   the test I added in https://github.com/apache/airflow/pull/22832/commits/fb87d0c63aadbf139a5bee353f4db290c5cc6794 shows a custom operator that uses it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org