You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2023/10/10 08:53:19 UTC
[PR] feat: document & streamline flight SQL CLI [arrow-rs]
crepererum opened a new pull request, #4912:
URL: https://github.com/apache/arrow-rs/pull/4912
# Which issue does this PR close?
\-
# Rationale for this change
Make flight SQL CLI usable by more people.
# What changes are included in this PR?
- add docs to README
- add a few more clap features
- document arguments
- unify key-value parsing for headers and parameters
# Are there any user-facing changes?
Yep, it's all better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: document & streamline flight SQL CLI [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #4912:
URL: https://github.com/apache/arrow-rs/pull/4912#discussion_r1353081239
##########
arrow-flight/src/bin/flight_sql_client.rs:
##########
@@ -81,31 +53,43 @@ pub struct LoggingArgs {
struct ClientArgs {
/// Additional headers.
///
- /// Values should be key value pairs separated by ':'
- #[clap(long, value_delimiter = ',')]
- headers: Vec<KeyValue<String, String>>,
+ /// Can be given multiple times. Headers and values are separated by '='.
+ ///
+ /// Example: `-H foo=bar -H baz=42`
Review Comment:
👍
##########
arrow-flight/src/bin/flight_sql_client.rs:
##########
@@ -81,31 +53,43 @@ pub struct LoggingArgs {
struct ClientArgs {
/// Additional headers.
///
- /// Values should be key value pairs separated by ':'
- #[clap(long, value_delimiter = ',')]
- headers: Vec<KeyValue<String, String>>,
+ /// Can be given multiple times. Headers and values are separated by '='.
+ ///
+ /// Example: `-H foo=bar -H baz=42`
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: document & streamline flight SQL CLI [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #4912:
URL: https://github.com/apache/arrow-rs/pull/4912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org