You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/12 08:19:13 UTC

[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

kimmking commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378095253
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java
 ##########
 @@ -119,6 +132,19 @@ public String getSchemaName(final String configurationNodeFullPath) {
         return result;
     }
     
+    /**
+     * Split sharding schema name.
+     * 
+     * @param shardingSchemaNames sharding schema names
+     * @return sharding schema names
+     */
+    public Collection<String> splitShardingSchemaName(final String shardingSchemaNames) {
+        if (Strings.isNullOrEmpty(shardingSchemaNames)) {
+            return Collections.emptyList();
+        }
+        return Splitter.on(",").splitToList(shardingSchemaNames);
 
 Review comment:
   constant?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services