[GitHub] [calcite] jamesstarr commented on a change in pull request #2475: [CALCITE-4544] Deprecating Reflection base Rel Metadata(James Starr)

[GitBox <gi...@apache.org>]

jamesstarr commented on a change in pull request #2475:
URL: https://github.com/apache/calcite/pull/2475#discussion_r712554117



##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptCluster.java
##########
@@ -146,18 +146,26 @@ public RexBuilder getRexBuilder() {
    * @param metadataProvider custom provider
    */
   @EnsuresNonNull({"this.metadataProvider", "this.metadataFactory"})
+  @SuppressWarnings("deprecation")
   public void setMetadataProvider(
       @UnknownInitialization RelOptCluster this,
       RelMetadataProvider metadataProvider) {
     this.metadataProvider = metadataProvider;
-    this.metadataFactory = new MetadataFactoryImpl(metadataProvider);
+    this.metadataFactory =
+        new org.apache.calcite.rel.metadata.MetadataFactoryImpl(metadataProvider);

Review comment:
       The deprecation test will fail if imports are used for a deprecated class.

##########
File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
##########
@@ -1582,7 +1589,7 @@ public String colType(MyRelMetadataQuery myRelMetadataQuery, RelNode rel, int co
     // generates a new call to the provider.
     final RelOptPlanner planner = rel.getCluster().getPlanner();
     rel.getCluster().setMetadataProvider(
-        new CachingRelMetadataProvider(
+        new org.apache.calcite.rel.metadata.CachingRelMetadataProvider(

Review comment:
       The deprecation test will fail if imports are used for a deprecated class.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org