[GitHub] michellethomas commented on a change in pull request #6251: [Fix] merge since, until request parameter with time_range

[GitBox <gi...@apache.org>]

michellethomas commented on a change in pull request #6251: [Fix] merge since, until request parameter with time_range
URL: https://github.com/apache/incubator-superset/pull/6251#discussion_r230148424
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1032,11 +1032,16 @@ def get_form_data(self, slice_id=None, use_slice_data=False):
             slc = db.session.query(models.Slice).filter_by(id=slice_id).first()
             slice_form_data = slc.form_data.copy()
             # allow form_data in request override slice from_data
+            if 'time_range' in form_data:
 
 Review comment:
   Add a comment like: we need to do this here so form_data has precedence over slice for time fields.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org