[GitHub] [lucene-solr] tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE

[GitBox <gi...@apache.org>]

tflobbe commented on a change in pull request #1247: SOLR-14252 use double rather than Double to avoid NPE
URL: https://github.com/apache/lucene-solr/pull/1247#discussion_r379047264
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/metrics/AggregateMetric.java
 ##########
 @@ -51,6 +61,18 @@ public String toString() {
           ", updateCount=" + updateCount +
           '}';
     }
+
+    public double toDouble() {
+      if (value instanceof Boolean) {
+        return 0;
+      } 
+      if (!(value instanceof Number)) {
+        log.debug("not a Number: " + value);
 
 Review comment:
   Can you use parametrized logging?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org