You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/03 17:54:54 UTC

[GitHub] holdenk commented on a change in pull request #4383: [AIRFLOW-3475] Move ImportError out of models.py

holdenk commented on a change in pull request #4383: [AIRFLOW-3475] Move ImportError out of models.py
URL: https://github.com/apache/incubator-airflow/pull/4383#discussion_r245079483
 
 

 ##########
 File path: airflow/models/importerror.py
 ##########
 @@ -0,0 +1,31 @@
+# -*- coding: utf-8 -*-
 
 Review comment:
   `exception.py` makes me think of Python exceptions, and `airflow/exceptions.py` contains Python exceptions. How about `errors.py` and we could group errors/failures in there? Just a thought.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services