[GitHub] spark pull request #21935: [SPARK-24773] Avro: support logical timestamp typ...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21935#discussion_r206742158
  
    --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala ---
    @@ -114,7 +121,10 @@ object SchemaConverters {
           case ByteType | ShortType | IntegerType => builder.intType()
           case LongType => builder.longType()
           case DateType => builder.longType()
    -      case TimestampType => builder.longType()
    +      case TimestampType =>
    +        // To be consistent with the previous behavior of writing Timestamp type with Avro 1.7,
    --- End diff --
    
    the previous behavior is: we can't write out timestamp data, isn't it?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org