You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Jay Booth (JIRA)" <ji...@apache.org> on 2009/11/03 00:08:59 UTC

[jira] Created: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

MultipleInputs fails with ClassCastException 
---------------------------------------------

                 Key: MAPREDUCE-1178
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
             Project: Hadoop Map/Reduce
          Issue Type: Bug
    Affects Versions: 0.21.0
            Reporter: Jay Booth
            Priority: Blocker
             Fix For: 0.21.0
         Attachments: MAPREDUCE-1178.patch

When running MultipleInputs against the new API, we get failures with this ClassCastException:

java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)

The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1178:
-----------------------------------------------

    Status: Open  (was: Patch Available)

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1178:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Cancelling patch, since it introduces a hack in LineRecordReader

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Jay Booth (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773076#action_12773076 ] 

Jay Booth commented on MAPREDUCE-1178:
--------------------------------------

Thanks Amareshwari, your patch is definitely much better.  

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772998#action_12772998 ] 

Hadoop QA commented on MAPREDUCE-1178:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12423895/patch-1178.txt
  against trunk revision 831816.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/221/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/221/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/221/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/221/console

This message is automatically generated.

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1178:
-----------------------------------------------

    Status: Patch Available  (was: Open)

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774902#action_12774902 ] 

Hudson commented on MAPREDUCE-1178:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #114 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/114/])
    . Fix ClassCastException in MultipleInputs by adding a DelegatingRecordReader. Contributed by Amareshwari Sriramadasu and Jay Booth.


> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1178:
-----------------------------------------------

    Attachment: patch-1178-1.txt

Added the java doc

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772833#action_12772833 ] 

Hadoop QA commented on MAPREDUCE-1178:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12423859/MAPREDUCE-1178.patch
  against trunk revision 831816.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/220/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/220/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/220/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/220/console

This message is automatically generated.

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1178:
-----------------------------------------------

    Attachment: patch-1178.txt

patch adds a DelegatingRecordReader which calls underlying record-reader methods for a split.
Thanks Jay for the testcase. Testcase passes with the patch.

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal updated MAPREDUCE-1178:
--------------------------------------

      Resolution: Fixed
        Assignee: Amareshwari Sriramadasu
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks Amareshwari and Jay.

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773015#action_12773015 ] 

Amareshwari Sriramadasu commented on MAPREDUCE-1178:
----------------------------------------------------

-1 contrib tests. Test failure is due to MAPREDUCE-1124

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773839#action_12773839 ] 

Sharad Agarwal commented on MAPREDUCE-1178:
-------------------------------------------

Patch looks great. Minor nit: Add javadoc to the public constructor of DelegatingRecordReader.

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1178:
-----------------------------------------------

    Status: Open  (was: Patch Available)

resubmitting for hudson

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1178:
-----------------------------------------------

    Status: Patch Available  (was: Open)

Ran ant javadoc, it passed successfully.

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774220#action_12774220 ] 

Hadoop QA commented on MAPREDUCE-1178:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12424114/patch-1178-1.txt
  against trunk revision 833275.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/228/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/228/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/228/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/228/console

This message is automatically generated.

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Jay Booth (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jay Booth updated MAPREDUCE-1178:
---------------------------------

    Attachment: MAPREDUCE-1178.patch

attached patch fixes ClassCastException and expands unit test to catch a wider variety of problems

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Jay Booth (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jay Booth updated MAPREDUCE-1178:
---------------------------------

    Status: Patch Available  (was: Open)

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775455#action_12775455 ] 

Hudson commented on MAPREDUCE-1178:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #139 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/139/])
    

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178-1.txt, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MAPREDUCE-1178) MultipleInputs fails with ClassCastException

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated MAPREDUCE-1178:
-----------------------------------------------

    Status: Patch Available  (was: Open)

> MultipleInputs fails with ClassCastException 
> ---------------------------------------------
>
>                 Key: MAPREDUCE-1178
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1178
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Jay Booth
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1178.patch, patch-1178.txt
>
>
> When running MultipleInputs against the new API, we get failures with this ClassCastException:
> java.lang.ClassCastException: org.apache.hadoop.mapreduce.lib.input.TaggedInputSplit cannot be cast to org.apache.hadoop.mapreduce.lib.input.FileSplit
> 	at org.apache.hadoop.mapreduce.lib.input.LineRecordReader.initialize(LineRecordReader.java:70)
> 	at org.apache.hadoop.mapreduce.lib.input.KeyValueLineRecordReader.initialize(KeyValueLineRecordReader.java:59)
> 	at org.apache.hadoop.mapred.MapTask$NewTrackingRecordReader.initialize(MapTask.java:439)
> 	at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:599)
> 	at org.apache.hadoop.mapred.MapTask.run(MapTask.java:323)
> 	at org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:257)
> The unit test for MultipleInputs doesn't actually run a job so this snuck through while still passing the unit test.  Attached patch fixes the unit test to expose the failure and does a little casting kung-fu in LineRecordReader to avoid the error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.