[jira] [Commented] (MAPREDUCE-2631) Potential resource leaks in BinaryProtocol$TeeOutputStream.java

["Devaraj K (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534627#comment-14534627 ] 

Devaraj K commented on MAPREDUCE-2631:
--------------------------------------

Thanks [~sunilg] for the updated patch.

https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5670/console
{code:xml}
-1 overall

| Vote |           Subsystem |  Runtime   | Comment
============================================================================
|   0  |          pre-patch  |  14m 46s   | Pre-patch trunk compilation is 
|      |                     |            | healthy.
|  +1  |            @author  |  0m 0s     | The patch does not contain any 
|      |                     |            | @author tags.
|  +1  |     tests included  |  0m 0s     | The patch appears to include 2 new 
|      |                     |            | or modified test files.
|  +1  |              javac  |  7m 39s    | There were no new javac warning 
|      |                     |            | messages.
|  +1  |            javadoc  |  9m 51s    | There were no new javadoc warning 
|      |                     |            | messages.
|  +1  |      release audit  |  0m 21s    | The applied patch does not increase 
|      |                     |            | the total number of release audit
|      |                     |            | warnings.
|  +1  |         checkstyle  |  1m 16s    | There were no new checkstyle 
|      |                     |            | issues.
|  +1  |         whitespace  |  0m 0s     | The patch has no lines that end in 
|      |                     |            | whitespace.
|  +1  |            install  |  1m 33s    | mvn install still works. 
|  +1  |    eclipse:eclipse  |  0m 32s    | The patch built with 
|      |                     |            | eclipse:eclipse.
|  +1  |           findbugs  |  1m 56s    | The patch does not introduce any 
|      |                     |            | new Findbugs (version 2.0.3)
|      |                     |            | warnings.
|  +1  |    mapreduce tests  |  1m 36s    | Tests passed in 
|      |                     |            | hadoop-mapreduce-client-core.
|  -1  |    mapreduce tests  |  97m 32s   | Tests failed in 
|      |                     |            | hadoop-mapreduce-client-jobclient.
|      |                     |  137m 6s   | 


             Reason | Tests
 Failed unit tests  |  hadoop.mapreduce.security.ssl.TestEncryptedShuffle 
                    |  hadoop.mapreduce.security.TestBinaryTokenFile 
                    |  hadoop.mapreduce.TestMapReduceLazyOutput 
                    |  hadoop.mapred.pipes.TestPipeApplication 
                    |  hadoop.mapreduce.TestMRJobClient 
{code}

Can you have a look into these failed tests?

> Potential resource leaks in BinaryProtocol$TeeOutputStream.java
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-2631
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2631
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.23.0
>            Reporter: Ravi Teja Ch N V
>            Assignee: Sunil G
>         Attachments: 0001-MAPREDUCE-2631.patch, MAPREDUCE-2631.1.patch, MAPREDUCE-2631.2.patch, MAPREDUCE-2631.3.patch, MAPREDUCE-2631.patch
>
>
> {code:title=BinaryProtocol$TeeOutputStream.java|borderStyle=solid}
> public void close() throws IOException {
>       flush();
>       file.close();
>       out.close();
>     }
> {code} 
> In the above code, if the file.close() throws any exception out will not be closed.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)