[GitHub] spark pull request: [MLLIB] Add fit intercept api to ml logisticre...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/5301#issuecomment-89065591
  
    @oefirouz  Thanks for the PR!  I agree we need to support this option, and that it should be set to True by default.
    
    Can you please make a JIRA and put it in the PR title?  "[SPARK-####] [MLLIB] Add fit..."
    
    I believe you're correct about normalization causing problems for an all-ones column; the other issue is that LR needs to know not to regularize the intercept term.
    
    I'll look at the code now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org