[GitHub] [tvm] mbs-octoml commented on a change in pull request #8835: Change target string to Target object in the TE compiler and interpreter

[GitBox <gi...@apache.org>]

mbs-octoml commented on a change in pull request #8835:
URL: https://github.com/apache/tvm/pull/8835#discussion_r698608157



##########
File path: src/relay/backend/interpreter.cc
##########
@@ -382,8 +386,10 @@ class Interpreter : public ExprFunctor<ObjectRef(const Expr& n)>,
 
     // Project out just the function(s) we need.
     IRModule lowered_projected_mod;
-    auto mod_itr = per_target_module_.find(target->str());
-    ICHECK(mod_itr != per_target_module_.end())
+    std::unordered_map<Target, IRModule, TargetStrHash, TargetStrEqual> per_target_module_std_map_ =

Review comment:
       nit: don't append a _ for local vars since the convention is it indicates a member var.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org