You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/02 13:56:43 UTC
[GitHub] [airflow] jyotidhiman0610 opened a new pull request #14030: [WIP]: Add Tableau provider separate from Salesforce Provider
jyotidhiman0610 opened a new pull request #14030:
URL: https://github.com/apache/airflow/pull/14030
Closes #13614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-784203144
@kaxil thanks for pointing it out! I disabled some pylint checks for pre-commit validation, removed the disabled tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: [WIP]: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-772110334
[The Workflow run](https://github.com/apache/airflow/actions/runs/531841975) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-782779673
[The Workflow run](https://github.com/apache/airflow/actions/runs/585389811) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: [WIP]: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-772110144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-782286110
Can you rebase it on latest Master please, for some reason, tests were skipped
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexInhert commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
alexInhert commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-785869238
I have a question about this.
to my understanding in Airflow 2 there is auto discovery of connection.
The tableau connection should be discovered from both Tableau and Salesforce providers (until tableau is removed from Salesforce). Will that be the case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-784241961
[The Workflow run](https://github.com/apache/airflow/actions/runs/592844445) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-772831100
[The Workflow run](https://github.com/apache/airflow/actions/runs/534945207) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #14030: [WIP]: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-772475360
Thanks @potiuk, I added one more commit for tableau provider tests.
Can you please let me know how can I test the backward compatibility of the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-782562230
@kaxil , I rebased & pushed. The tests were cancelled due to Image build failure, can you please guide me a bit to achieve a green build. How do I avoid tests being skipped/cancelled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-783086294
[The Workflow run](https://github.com/apache/airflow/actions/runs/588046422) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-782555678
@kaxil will do!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14030:
URL: https://github.com/apache/airflow/pull/14030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-783086162
[The Workflow run](https://github.com/apache/airflow/actions/runs/588046439) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-782913641
Can you plese rebase @jyotidhiman0610 -> we had some pylint problems, but they were since solved and if you rebase to latest master, they should be solved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-785880823
That's good point. If you have both providers installed, only one of the connection should register (and there should be a warning in the log). Since they are effectively the same class (from Tableau provider) it does not matter which one gets first (it will be the tableau one because they are alphabetically sorted).
So it should all work fine :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-785857118
Thanks @jyotidhiman0610 🎉 for the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-775953156
[The Workflow run](https://github.com/apache/airflow/actions/runs/551513262) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-775947761
[The Workflow run](https://github.com/apache/airflow/actions/runs/551452792) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 edited a comment on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 edited a comment on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-772475360
Thanks @potiuk, I added one more commit for tableau provider tests and logo.
Can you please help me in testing the backward compatibility of the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 edited a comment on pull request #14030: [WIP]: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 edited a comment on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-772475360
Thanks @potiuk, I added one more commit for tableau provider tests.
Can you please help me in testing the backward compatibility of the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-785880823
That's good point. If you have both providers installed, only one of the connections should register (and there should be a warning in the log). Since they are effectively the same class (from Tableau provider) it does not matter which one gets first (it will be the tableau one because they are alphabetically sorted).
So it should all work fine :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-782560370
[The Workflow run](https://github.com/apache/airflow/actions/runs/583457531) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: [WIP]: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-772110144
[The Workflow run](https://github.com/apache/airflow/actions/runs/531793994) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-785634706
@kaxil / @potiuk The failing tests seems intermittent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jyotidhiman0610 commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
jyotidhiman0610 commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-783074441
@potiuk rebased with latest master & pushed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14030: [WIP]: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-772471827
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14030: Add Tableau provider separate from Salesforce Provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14030:
URL: https://github.com/apache/airflow/pull/14030#issuecomment-784153849
Some of the static tests are failing:
```
Run pylint for tests.....................................................Failed
- hook id: pylint
- exit code: 2
************* Module hooks.test_tableau
tests/providers/tableau/hooks/test_tableau.py:25:0: E0012: Bad option value 'do-not-use-asserts' (bad-option-value)
************* Module operators.test_tableau_refresh_workbook
tests/providers/tableau/operators/test_tableau_refresh_workbook.py:26:0: E0012: Bad option value 'do-not-use-asserts' (bad-option-value)
************* Module sensors.test_tableau_job_status
tests/providers/tableau/sensors/test_tableau_job_status.py:29:0: E0012: Bad option value 'do-not-use-asserts' (bad-option-value)
------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org