You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/09/18 04:10:02 UTC

[Bug 121001] New: [From Symphony]Macro doesn't work if click "Undo" button

https://issues.apache.org/ooo/show_bug.cgi?id=121001

          Priority: P3
            Bug ID: 121001
                CC: ooo-issues@incubator.apache.org
          Assignee: issues@vba.openoffice.org
           Summary: [From Symphony]Macro doesn't work if click "Undo"
                    button
          Severity: normal
        Issue Type: DEFECT
    Classification: Code
                OS: All
          Reporter: yanji.yj@gmail.com
          Hardware: All
            Status: CONFIRMED
           Version: AOO350-dev
         Component: code
           Product: vba

Created attachment 79539
  --> https://issues.apache.org/ooo/attachment.cgi?id=79539&action=edit
sample

Build: AOO 3.5 Trunk Rev. r1384699
OS: Windows
Steps:
1. Enable macro and allow execute executable code in option setting
2. Load sample file
3. Without any other action, the "Undo" button is enabled
4. Click "Undo" button
5. Click button

Defect: Macro code cannot be executed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

Shenfeng Liu <li...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |liushenf@gmail.com
   Target Milestone|---                         |AOO 3.5.0

--- Comment #9 from Shenfeng Liu <li...@gmail.com> ---
Update Target Milestone to AOO 3.5.0.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

Lei Debin <de...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79570|                            |review?
              Flags|                            |

--- Comment #5 from Lei Debin <de...@gmail.com> ---
Created attachment 79570
  --> https://issues.apache.org/ooo/attachment.cgi?id=79570&action=edit
patch for the issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

Du Jing <bj...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|VERIFIED                    |CLOSED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

Du Jing <bj...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED
                 CC|                            |bjdujing@gmail.com

--- Comment #8 from Du Jing <bj...@gmail.com> ---
verified on the build AOO3.5_r1397404

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

Lei Debin <de...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |debin.lei@gmail.com

--- Comment #1 from Lei Debin <de...@gmail.com> ---
I am checking the issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

--- Comment #3 from Lei Debin <de...@gmail.com> ---
For another objects, not form control, but drawing, graphic and so on, can
reproduce the undo issue. So I figure out a simple solution, after convert
finishing, call the GetUndoManager()->Clear() to clear the undo action.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

--- Comment #2 from Lei Debin <de...@gmail.com> ---
After more investigation, when the file(.xls) loading, function ConvertFrom
will called, and some convert action will add to Undo manager. So user can see
some undo action from the UI. The behavior is abnormal. The file after loading,
should NOT have any undo action.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |AOO 4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

Lei Debin <de...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Lei Debin <de...@gmail.com> ---
@jianyuan, thx your review.
Now, the patch had been committed in Revision: 1389676

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

Jianyuan Li <li...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lijianyuan1983@gmail.com

--- Comment #4 from Jianyuan Li <li...@gmail.com> ---
Please add the patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 121001] [From Symphony]Macro doesn't work if click "Undo" button

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=121001

--- Comment #6 from Jianyuan Li <li...@gmail.com> ---
Review and tested. OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.