You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/03/18 01:32:29 UTC
[GitHub] [ratis] kaijchen opened a new pull request #625: RATIS-1028. [Checkstyle] Enable AvoidStarImport
kaijchen opened a new pull request #625:
URL: https://github.com/apache/ratis/pull/625
## What changes were proposed in this pull request?
Enable AvoidStarImport in checksytle config and fix violations.
Besides, there is also some alphabetical reordering, which I think is nice to have.
Only the files with `import *` were visited and changed.
This was discussed before at #173.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1028
## How was this patch tested?
checkstyle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] kaijchen commented on pull request #625: RATIS-1028. [Checkstyle] Enable AvoidStarImport
Posted by GitBox <gi...@apache.org>.
kaijchen commented on pull request #625:
URL: https://github.com/apache/ratis/pull/625#issuecomment-1071948522
> Let's do not enable AvoidStarImport. Let's spend more time on the code but not on the imports. I really appreciate your effort!
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] kaijchen closed pull request #625: RATIS-1028. [Checkstyle] Enable AvoidStarImport
Posted by GitBox <gi...@apache.org>.
kaijchen closed pull request #625:
URL: https://github.com/apache/ratis/pull/625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #625: RATIS-1028. [Checkstyle] Enable AvoidStarImport
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #625:
URL: https://github.com/apache/ratis/pull/625#issuecomment-1071945785
@kaijchen , thanks for the suggestion.
Let's do not enable AvoidStarImport. Let's spend more time on the code but not on the imports. I really appreciate your effort!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] kaijchen closed pull request #625: RATIS-1028. [Checkstyle] Enable AvoidStarImport
Posted by GitBox <gi...@apache.org>.
kaijchen closed pull request #625:
URL: https://github.com/apache/ratis/pull/625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] szetszwo commented on pull request #625: RATIS-1028. [Checkstyle] Enable AvoidStarImport
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #625:
URL: https://github.com/apache/ratis/pull/625#issuecomment-1071945785
@kaijchen , thanks for the suggestion.
Let's do not enable AvoidStarImport. Let's spend more time on the code but not on the imports. I really appreciate your effort!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis] kaijchen commented on pull request #625: RATIS-1028. [Checkstyle] Enable AvoidStarImport
Posted by GitBox <gi...@apache.org>.
kaijchen commented on pull request #625:
URL: https://github.com/apache/ratis/pull/625#issuecomment-1071948522
> Let's do not enable AvoidStarImport. Let's spend more time on the code but not on the imports. I really appreciate your effort!
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org