You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "mariiaKraievska (via GitHub)" <gi...@apache.org> on 2025/01/30 13:16:20 UTC
[PR] FINERACT-2205: Add tests when charge is added after the charge off date and behavior is zero-interest [fineract]
mariiaKraievska opened a new pull request, #4292:
URL: https://github.com/apache/fineract/pull/4292
## Description
Add tests for test cases S9-3 and S9-4 when behaviour is "zero-interest".
https://mifosforge.jira.com/browse/PS-2205
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2205: Add tests when charge is added after the charge off date and behavior is zero-interest [fineract]
Posted by "mariiaKraievska (via GitHub)" <gi...@apache.org>.
mariiaKraievska commented on code in PR #4292:
URL: https://github.com/apache/fineract/pull/4292#discussion_r1939282436
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -3581,4 +3581,17 @@ public boolean isChargeOffOnDate(final LocalDate onDate) {
return (chargeOffTransaction == null) ? false : (chargeOffTransaction.getDateOf().compareTo(onDate) <= 0);
}
+ public boolean hasMonetaryActivityAfter(final LocalDate transactionDate) {
+ for (LoanTransaction transaction : this.getLoanTransactions()) {
+ if (transaction.getTransactionDate().isAfter(transactionDate) && !transaction.isNonMonetaryTransaction()) {
+ return true;
+ }
+ }
+ for (LoanCharge loanCharge : this.getLoanCharges()) {
+ if (!loanCharge.isPaid() && loanCharge.getSubmittedOnDate().isAfter(transactionDate)) {
Review Comment:
Done, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2205: Add tests when charge is added after the charge off date and behavior is zero-interest [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #4292:
URL: https://github.com/apache/fineract/pull/4292#discussion_r1939089698
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -3581,4 +3581,17 @@ public boolean isChargeOffOnDate(final LocalDate onDate) {
return (chargeOffTransaction == null) ? false : (chargeOffTransaction.getDateOf().compareTo(onDate) <= 0);
}
+ public boolean hasMonetaryActivityAfter(final LocalDate transactionDate) {
+ for (LoanTransaction transaction : this.getLoanTransactions()) {
+ if (transaction.getTransactionDate().isAfter(transactionDate) && !transaction.isNonMonetaryTransaction()) {
+ return true;
+ }
+ }
+ for (LoanCharge loanCharge : this.getLoanCharges()) {
+ if (!loanCharge.isPaid() && loanCharge.getSubmittedOnDate().isAfter(transactionDate)) {
Review Comment:
You might wanna include `isWaived` and `isWrittenOff` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2205: Add tests when charge is added after the charge off date and behavior is zero-interest [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #4292:
URL: https://github.com/apache/fineract/pull/4292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org