You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/13 08:40:39 UTC
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1968: feat: When Dashboard and APISIX version do not match, make the prompt information clearer (#1944)
nic-chen commented on a change in pull request #1968:
URL: https://github.com/apache/apisix-dashboard/pull/1968#discussion_r668552867
##########
File path: api/internal/handler/tool/tool.go
##########
@@ -101,9 +102,11 @@ func (h *Handler) VersionMatch(c droplet.Context) (interface{}, error) {
} else {
// TODO: move this to utils
return &data.SpecCodeResponse{StatusCode: http.StatusOK, Response: data.Response{
- Data: &output,
- Code: 2000001,
- Message: "The manager-api and apache apisix are mismatched.",
+ Data: &output,
+ Code: 2000001,
+ Message: fmt.Sprintf("The Manager-api and Apache APISIX are mismatched. "+
Review comment:
```suggestion
Message: fmt.Sprintf("The Manager API and Apache APISIX are mismatched. "+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org