You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/23 16:38:42 UTC

[GitHub] [arrow] markhildreth commented on a change in pull request #6972: ARROW-8287: [Rust] Add "pretty" util to help with printing tabular output of RecordBatches

markhildreth commented on a change in pull request #6972:
URL: https://github.com/apache/arrow/pull/6972#discussion_r413951619



##########
File path: rust/parquet/src/encodings/rle.rs
##########
@@ -830,7 +826,7 @@ mod tests {
             values.clear();
             let mut rng = thread_rng();
             let seed_vec: Vec<u8> =
-                Standard.sample_iter(&mut rng).take(seed_len).collect();
+                rng.sample_iter::<u8, _>(&Standard).take(seed_len).collect();

Review comment:
       This is an example of type inferences that would become compiler errors with the inclusion of the `prettytable-rs` crate. I have fixed this code, but the original error being generated was:
   
   ```
   error[E0282]: type annotations needed
      --> parquet/src/encodings/rle.rs:833:26
       |
   833 |                 Standard.sample_iter(&mut rng).take(seed_len).collect();
       |                          ^^^^^^^^^^^ cannot infer type for `T`
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org